PATCH: add an assert to gas/dw2gencfi.c

Jan Beulich jbeulich@novell.com
Tue Oct 24 09:05:00 GMT 2006


>--- dw2gencfi.c 27 Feb 2006 23:07:06 -0000      1.28
>+++ dw2gencfi.c 24 Oct 2006 04:53:16 -0000
>@@ -256,6 +256,8 @@ cfi_add_CFA_offset (unsigned regno, offs
> 
>   abs_data_align = (DWARF2_CIE_DATA_ALIGNMENT < 0
>                    ? -DWARF2_CIE_DATA_ALIGNMENT : DWARF2_CIE_DATA_ALIGNMENT);
>+
>+  assert (abs_data_align > 0);
>   if (offset % abs_data_align)
>     as_bad (_("register save offset not a multiple of %u"), abs_data_align);
> }

I have to admit that I'd find it more obvious to put the assert before
the assignment, and have DWARF2_CIE_DATA_ALIGNMENT be its
subject; if there is no potential for this not being a compile-time
constant, then this could even become a build-time assertion rather
than a run-time one.

Jan



More information about the Binutils mailing list