[rfa] ARM dangerous relocations are ... dangerous

Daniel Jacobowitz drow@false.org
Tue Nov 7 14:58:00 GMT 2006


On Fri, Nov 03, 2006 at 02:50:52PM +0000, Nick Clifton wrote:
> Hi Daniel,
> 
> >2006-11-01  Daniel Jacobowitz  <dan@codesourcery.com>
> >
> >	* elf32-arm.c (find_thumb_glue): Add ERROR_MESSAGE argument; set it
> >	on error.
> >	(find_arm_glue): Likewise.
> >	(elf32_thumb_to_arm_stub, elf32_arm_create_thumb_stub)
> >	(elf32_arm_to_thumb_stub, elf32_arm_final_link_relocate): Add
> >	ERROR_MESSAGE argument and pass it through.
> >	(elf32_arm_to_thumb_export_stub): Update.
> >	(elf32_arm_relocate_section): Use ERROR_MESSAGE and reloc_dangerous.
> 
> Approved - please apply, although...

Thanks, done.

> This feels wrong to me, since error_message is never really used in the 
> function.  Maybe the BFD_ASSERT ought to be changed to check the return 
> value and use the error message if myh is NULL ?

It is a bit nasty.  But I thought about this for a while and applied it
the way it was - it turns out the error message you'd get there makes sense
in the first context, but not at this call site, so I'd have to
refactor it all again.  Maybe some other time :-(

-- 
Daniel Jacobowitz
CodeSourcery



More information about the Binutils mailing list