[patch] Arm BE8 stubs

Nick Clifton nickc@redhat.com
Wed May 24 12:56:00 GMT 2006


Hi Paul,

> 2006-05-18  Paul Brook  <paul@codesourcery.com>
> 
> 	* elf32-arm.c (put_arm_insn, put_thumb_insn): New functions.
> 	(elf32_thumb_to_arm_stub, elf32_arm_to_thumb_stub,
> 	elf32_arm_finish_dynamic_symbol): Use them.

Approved - please apply - but ...

> +static void
> +put_arm_insn(struct elf32_arm_link_hash_table *htab,

Formatting:  There should be a space before the opening parenthesis.

> +      bfd_putl32(val, ptr);
> +    else
> +      bfd_putb32(val, ptr);

Formatting again: More spaces before opening parentheses please.
(Similarly for put_thumb_insn as well).

Cheers
   Nick



More information about the Binutils mailing list