[patch] Arm BE8 mode and mapping sybols

Nick Clifton nickc@redhat.com
Sun May 7 21:32:00 GMT 2006


Hi Paul,

> +  /* We only want 'a', 't' and 'd' mapping symbols.  */
> +  if (! bfd_is_arm_mapping_symbol_name (name)
> +      || (name[1] != 'a' && name[1] != 't' && name[1] != 'd'))
>      return TRUE;

Actually I think that it would be cleaner if 
bfd_is_arm_mapping_symbol_name() took a second argument which 
distinguishes between a request for any mapping symbol versus a request 
for only-valid-for-modern-ABIs mapping symbol.  That way the knowledge 
about which symbols are valid can be kept in one place, with the code 
that actually detects them.

Cheers
   Nick



More information about the Binutils mailing list