Allow fdaddl %dX,%fpY on Coldfire

Ben Elliston bje+dated+1154595161.cadeda@air.net.au
Sat Jul 29 08:52:00 GMT 2006


> The patch fixes the opcodes entry for Coldfire's fdaddl insn.  The
> source operand had a "w" marker (modes 2-4, 7.2) whereas it should
> have had a "b" marker (modes 0, 2-4, 7.2).  gas would therefore
> treat "fdaddl %dX,%fpY" as having an invalid combination of
> operands.

OK.

> I think the wrong format was probably a cut-&-pasto from something
> like "fdaddd".  I also think it was just an isolated error; I
> checked the table and all other f*[bwls] opcodes appear to be
> correct (i.e., already use "b").  To be sure, I added tests for
> every addressing mode to mcf-fpu.s.

Thanks for your diligence!

Cheers, Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20060729/707cbebf/attachment.sig>


More information about the Binutils mailing list