simplify some Xtensa GAS error messages

Bob Wilson bwilson@tensilica.com
Tue Feb 14 09:34:00 GMT 2006


Some of the Xtensa-specific error messages were reporting operand positions with 
numbers starting from zero, which was confusing.  This patch changes them to use 
  numbers starting from one.

Some other messages were confusing when the assembler relaxes the instruction, 
because the opcode and operand shown in the error message did not match the 
source.  The patch changes these messages to omit the opcode and operand 
information.  It would be nice to provide the more detailed information, but the 
line number and an "invalid symbolic operand" message is usually sufficient to 
identify the problem, and the extra information can be really confusing when it 
doesn't match.

Tested with an xtensa-elf build and committed on the mainline.

2006-02-13  Bob Wilson  <bob.wilson@acm.org>

	* config/tc-xtensa.c (xg_add_opcode_fix): Number operands starting
	from 1, not 0, in error messages.
	(md_assemble): Simplify special-case check for ENTRY instructions.
	(tinsn_has_invalid_symbolic_operands): Do not include opcode and
	operand in error message.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gas-errmsgs.diff
Type: text/x-patch
Size: 2293 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20060214/1675f54f/attachment.bin>


More information about the Binutils mailing list