[PATCH] MIPS gas: Fix broken relocation sorting

David Daney ddaney@avtrex.com
Mon Dec 11 16:37:00 GMT 2006


Thiemo Seufer wrote:
> David Daney wrote:
>   
>> Richard Sandiford wrote:
>>     
>>> Thus if we were indeed converting R_MIPS_GOT16 relocations against
>>> local symbols into R_MIPS_GOT16 relocations against global symbols,
>>> (1) would be the right fix.  But like I say, the bug appears at
>>> first glance to be in pic_need_relax.
>>>
>>>       
>> New version of the patch:
>>
>> Tested as before with mipsel-linux cross build no regressions.
>>
>> OK to commit?
>>
>> If this looks better, I will restart my gcc-4.2 boot strap with this 
>> instead.
>>
>> gas:
>> 2006-11-06  David Daney  <ddaney@avtrex.com>
>>
>> 	* config/tc-mips.c (pic_need_relax): Return true for section symbols.
>>
>> gas/testsuite:
>> 2006-11-06  David Daney  <ddaney@avtrex.com>
>>
>> 	* gas/mips/elf-rel26.s: New test.
>> 	* gas/mips/elf-rel26.d: Ditto.
>> 	* gas/mips/mips.exp: Run it.
>>     
>
> Ok.
>
>
> Thiemo
>   
Can I put this in the 2.17 branch as well?  I have successfully 
bootstrapped and tested GCC 4.2 and 4.3 several times with binutils 2.17 
+ this patch with good results.

Also a related question:  Is there going to be another official release 
from the 2.17 branch? 

David Daney



More information about the Binutils mailing list