[PATCH]: Add DWARF debugging format support for arm-wince-pe

Nick Clifton nickc@redhat.com
Sun Aug 6 14:15:00 GMT 2006


Hi Pedro,

> Updated patch for gas attached.

There are still a few minor problems with this part of the patch:

> +#ifdef TE_PE
> +static void pe_directive_secrel PARAMS ((int));

There is no need for this declaration, it is redundant.  Plus we are not 
using the PARAMS macro any more.

> +static void
> +pe_directive_secrel (dummy)
> +int dummy ATTRIBUTE_UNUSED;

We are following the ISO-C90 standard now, so the type qualifiers for 
function arguments should be included in the declaration, ie:

   pe_directive_secrel (int dummy ATTRIBUTE_UNUSED)


With these two changes the entire patch is approved.

Cheers
   Nick




More information about the Binutils mailing list