[patch RFC] Fix PR binutils/2584
Kaz Kojima
kkojima@rr.iij4u.or.jp
Thu Apr 27 18:25:00 GMT 2006
Alan Modra <amodra@bigpond.net.au> wrote:
>> while (len--)
>> value = value << 4 | hex_value(*src++);
>
> You missed checking for a valid hex number here. Otherwise the patch
> looks OK.
Oops. I'll change that lines to
while (len--)
{
if (!ISHEX (*src))
return FALSE;
value = value << 4 | hex_value (*src++);
}
and commit the patch after the test. Thanks for reviewing.
Regards,
kaz
More information about the Binutils
mailing list