Re ld/dlltool - .def file format error
Danny Smith
dannysmith@clear.net.nz
Sat Apr 1 04:58:00 GMT 2006
> -----Original Message-----
> From: Christopher Faylor
> Sent: Saturday, April 01, 2006 4:36 AM
>
>
> On Fri, Mar 31, 2006 at 05:47:21PM +1200, Danny Smith wrote:
> >2006-03-31 Danny Smith <dannysmith@users.sourceforge.net>
> >
> > * deffilep.y (def_image_name): If LIBRARY or NAME statement
> > specifies an empty string, retain the name specified on command
> > line.
> > * ld.texinfo: Document above.
> >
> >
> >Index: src/ld/deffilep.y
<snip>
> >--- 648,679 ----
> > static void
> > def_image_name (const char *name, int base, int is_dll)
> > {
> >! if (*name == 0)
> >! /* A LIBRARY or NAME statement without a name: Nothing to do.
> >! We retain the output filename specified on command line. */
> >! ;
> > else
>
> Wouldn't it be clearer to just move this comment above the if
> test and change the test to
>
> if (*name)
>
> ?
>
> If you agree, then please check that in. I agree that this
> is a nice change
>
> cgf
Committed, with suggested change.
Danny
More information about the Binutils
mailing list