PATCH: readelf: Apply relocation addends to whole section

Nick Clifton nickc@redhat.com
Fri Sep 30 16:07:00 GMT 2005


Hi H. J.

> FYI, both the current and new debug_apply_rela_addends assumes the
> relocation field size is fixed. But this is wrong. On x86-64, 
> relocations with both 32bit and 64bit fields, R_X86_64_32 and
> R_X86_64_64, may be used in DWARF info. We are lucky so far since
> we don't have appends > 32bits even for 64bit fields in most cases. To
> properly fix it, we need to get the field size based on the relocation
> type.

Agreed - we will have to look into this.

> 2005-09-02  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* readelf.c (debug_apply_rela_addends): Relocate the whole
> 	section.
> 	(process_debug_info): Don't call debug_apply_rela_addends.
> 	(display_debug_frames): Likewise.
> 	(get_debug_info): Call debug_apply_rela_addends.
> 	(debug_displays): Add the "relocate" field.
> 	(display_debug_section): Call debug_apply_rela_addends if
> 	needed.

Approved - please apply.

Cheers
   Nick



More information about the Binutils mailing list