PATCH: use hashtab for pseudo op table

Nick Clifton nickc@redhat.com
Thu May 5 11:46:00 GMT 2005


Hi Alan,

>>I agree - Ben, what is your motivation for removing hash.c ?

> Probably because I was talking to Ben a week or so ago, and mentioned
> that it's silly that we have so many hash table implementations.  We
> have libiberty/hashtab.c, bfd/hash.c, and gas/hash.c.  Some of bfd
> already uses libiberty/hashtab.c due to it's rather nice auto-resize,
> and more of bfd should.  ie. I see libiberty/hashtab.c as the way of
> the future.

Well removing multiple implementations of the same thing is certainly good.

I guess the question comes down to - should bfd keep or re-implement its 
own hashtab code to be used everywhere in binutils or should the one 
from libiberty be used ?  Zack pointed out the performance penalty of 
using libiberty's code, and I would like to get a feel for whether this 
would be a serious hindrance to using it.

Cheers
   Nick




More information about the Binutils mailing list