[PATCH] Fix type and alignment of ARM/Thumb EABI mapping symbols

Richard Earnshaw rearnsha@gcc.gnu.org
Thu Mar 31 15:25:00 GMT 2005


On Wed, 2005-03-30 at 18:05, Julian Brown wrote:
> Richard Earnshaw wrote:
> > On Wed, 2005-03-30 at 17:34, Julian Brown wrote:
> >>Richard Earnshaw wrote:
> >>>This function isn't elf specific, which is one of the reasons I
> >>>suggested moving it to cpu-arm.c.  So why have you put elf32 in the
> >>>name?
> >>
> >>Doh, sorry. I was confused by the mapping symbols being defined by the 
> >>AAELF spec, and didn't realise they would be used elsewhere too.
> > 
> > True, but we don't define a coff spec.  However, I suspect that if we
> > did, we'd probably put mapping symbols in there too.
> 
> OK, here is a further patch to rename the function.
> 
> ChangeLog:
> 
> bfd:
>    * bfd-in.h (bfd_is_arm_mapping_symbol_name): Rename from
>    bfd_elf32_is_arm_mapping_symbol_name.
>    * bfd-in2.h: Regenerate.
>    * cpu-arm.c (bfd_is_arm_mapping_symbol_name): Rename from
>    bfd_elf32_is_arm_mapping_symbol_name.
>    * elf32-arm.c (elf32_arm_is_target_special_symbol): Rename
>    bfd_elf32_is_arm_mapping_symbol_name to bfd_is_arm_mapping_symbol_name.
>    (arm_elf_find_function): Likewise.
>    (elf32_arm_output_symbol_hook): Likewise.
> 
> gas:
>    * config/tc-arm.c (arm_adjust_symtab): Rename
>    bfd_elf32_is_arm_mapping_symbol_name to bfd_is_arm_mapping_symbol_name.

This one counts as obvious :-)

R.



More information about the Binutils mailing list