[PATCH] Fix type and alignment of ARM/Thumb EABI mapping symbols

Richard Earnshaw rearnsha@gcc.gnu.org
Thu Mar 31 00:58:00 GMT 2005


On Wed, 2005-03-30 at 17:34, Julian Brown wrote:
> Richard Earnshaw wrote:
> > On Wed, 2005-03-30 at 16:31, Julian Brown wrote:
> > 
> > 
> >>   * bfd/cpu-arm.c (bfd_elf32_is_arm_mapping_symbol_name): ...to here,
> >>   renamed and made global.
> > 
> > 
> > This function isn't elf specific, which is one of the reasons I
> > suggested moving it to cpu-arm.c.  So why have you put elf32 in the
> > name?
> 
> Doh, sorry. I was confused by the mapping symbols being defined by the 
> AAELF spec, and didn't realise they would be used elsewhere too.
> 
True, but we don't define a coff spec.  However, I suspect that if we
did, we'd probably put mapping symbols in there too.

> Is the original name best, or would bfd_is_arm_mapping_symbol_name be 
> better?
> 

bfd_is_arm_mapping_symbol_name is fine.

R.



More information about the Binutils mailing list