[PATCH] Fix type and alignment of ARM/Thumb EABI mapping symbols

Julian Brown julian@codesourcery.com
Wed Mar 30 21:11:00 GMT 2005


Paul Brook wrote:
>>>!       4.5.7 Mapping symbols
>>>
>>>!       A section of an ELF file can contain a mixture of ARM code, Thumb
>>>code
>>
>>There's no need to quote the entirety of this section in the source
>>file.  A cross reference is fine.  The correct reference should be to
>>v1.0 of the spec, where the section number is 4.5.5.
> 
> 
> Might also be worth explicitly noting that this is a change from previous 
> behaviour.

I'll apply this version on mainline and binutils-csl-arm-2005q1-branch.

ChangeLog:

   * bfd/bfd-in.h (bfd_elf32_is_arm_mapping_symbol_name): Add prototype.
   * bfd/bfd-in2.h: Regenerate.
   * bfd/elf32-arm.c (elf32_arm_is_target_special_symbol): Rename call to
   bfd_elf32_is_arm_mapping_symbol_name.
   (elf32_arm_output_symbol_hook): Likewise.
   (arm_elf_find_function): Likewise, and include STT_NOTYPE in test
   for mapping symbols.
   (is_arm_mapping_symbol_name): Function moved from here...
   * bfd/cpu-arm.c (bfd_elf32_is_arm_mapping_symbol_name): ...to here,
   renamed and made global.
   * gas/config/tc-arm.c (mapping_state): Change documentation in
   function comment to cross-reference spec instead. Change type of
   mapping symbols to BSF_NO_TYPE.
   (arm_adjust_symtab): Don't change type of mapping symbols here.
   * gas/testsuite/gas/arm/mapping.d: Update expected output.
   * ld/testsuite/ld-arm/arm-app-abs32.d: Likewise.
   * ld/testsuite/ld-arm/arm-app.d: Likewise.
   * ld/testsuite/ld-arm/mixed-app.d: Likewise.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch-6
URL: <https://sourceware.org/pipermail/binutils/attachments/20050330/f3513255/attachment.ksh>


More information about the Binutils mailing list