elf32-arm.c corrections

Daniel Jacobowitz drow@false.org
Sun Mar 27 23:56:00 GMT 2005


On Sat, Mar 26, 2005 at 06:27:08PM +0100, Peter S. Mazinger wrote:
> On Sun, 20 Mar 2005, Daniel Jacobowitz wrote:
> 
> > On Sun, Mar 20, 2005 at 10:26:12AM +0100, Peter S. Mazinger wrote:
> > > On Sat, 19 Mar 2005, Daniel Jacobowitz wrote:
> > > 
> > > > On Sun, Mar 20, 2005 at 02:15:24AM +0100, Peter S. Mazinger wrote:
> > > > > Hello!
> > > > > 
> > > > > add_dynamic_entry: changes !info->shared to info->executable (PIE)
> > > > > corrects typo, and syncs up with other archs (some others could do the 
> > > > > same). For !relocs the hole part would be omitted, probably some speed gain.
> > > > 
> > > > Um, why are disabling the setting of DT_TEXTREL for shared libraries?
> > > 
> > > The 1 line removal is because none of the archs has that.
> > > The i386 implementation has everything within if (relocs), the other 
> > > archs have it outside, but DT_TEXTREL is only valid for if (relocs), so we 
> > > would omit that part gaining some speed
> > 
> > Ah, not enough context in the diff.  Makes sense.
> 
> Please apply then, I have signed aggreement, no cvs access

I don't approve ARM patches, sorry.

-- 
Daniel Jacobowitz
CodeSourcery, LLC



More information about the Binutils mailing list