[PATCH-ping] VAX: Forced decoding of function entry masks (eg. for disassembling ROM images)
Nick Clifton
nickc@redhat.com
Thu Mar 24 21:01:00 GMT 2005
Hi Jan-Benedict,
> I cannot do that on my own. AFAICT, I've only done all the FSF
> paperwork, but that doesn't come along with write privilege (and
> I'm not the VAX port maintainer).
OK - well I was going through the process of applying your patch when I
discovered several more, err not bugs, but features, which I thought
needed to be addressed. Specifically:
* The new feature of the disassembler should be mentioned in the
binutils NEWS file.
* Parsing the disassembler options string every time print_insn_vax()
is called seems to be hugely wasteful. Surely it is better to parse it
just once.
* When free_private_data() is called it does not reset the
entry_array and num_entry_fields to zero, so that the next time
init_private_data is called it will try to realloc freed memory.
* What is the purpose of the private structure anyway ? It seems
simpler to just a couple of static variables here.
Rather than just complain however, I have produced an alternative
version of your patch which addresses most of these issues (attached).
What do you think ? (Also, if you do like it, please could you test it
as I have now way of doing so myself).
Cheers
Nick
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: vax.dis.patch
URL: <https://sourceware.org/pipermail/binutils/attachments/20050324/a10da360/attachment.ksh>
More information about the Binutils
mailing list