PATCH: Fix MIPS DT_MIPS_UNREFEXTNO

H. J. Lu hjl@lucon.org
Tue Mar 22 11:52:00 GMT 2005


On Mon, Mar 21, 2005 at 06:00:48PM -0800, Eric Christopher wrote:
> I've not looked at the rest of the patch, but large #if 0 blocks without
> commenting isn't OK.
> 
> >        struct mips_got_info *g;
> > +#if 0
> >        bfd_size_type dynsecsymcount;
> >  
> >        /* When we resort, we must tell mips_elf_sort_hash_table what
> > @@ -8927,8 +8960,9 @@ _bfd_mips_elf_final_link (bfd *abfd, str
> >  		&& !(*bed->elf_backend_omit_section_dynsym) (abfd, info, p))
> >  	      ++ dynsecsymcount;
> >  	}
> > +#endif

It should be deleted. But I am not familiar with MIPS so that I left
it there just in case.


H.J.



More information about the Binutils mailing list