Committed, MMIX: Fix 64-bit host (opcodes/mmix-opc.c)

H. J. Lu hjl@lucon.org
Sun Mar 20 13:27:00 GMT 2005


On Sat, Mar 19, 2005 at 01:53:04PM -0500, Hans-Peter Nilsson wrote:
> On Sat, 19 Mar 2005, H. J. Lu wrote:
> > On Fri, Mar 18, 2005 at 11:30:41PM -0500, Hans-Peter Nilsson wrote:
> > > 	* mmix-opc.c (O, Z): Force expression as unsigned long.
> > >
> >
> > It isn't enough. I checked in the following patch to mainline to
> > fix it. I suggest you check it to 2.16 branch.
> 
> Please explain what faults you saw; "isn't enough" isn't enough
> to warrant this patch, which I don't see the obviousity in
> without further explanation.  Alternatively, revert it.
> 
> FWIW, I checked that this patch fixed the GAS testsuite errors
> on a RH Ent AS 3.0 x86_64-unknown-linux-gnu with "gcc
> version 3.2.3 20030502 (Red Hat Linux 3.2.3-49)" aka.
> spe189.testdrive.hp.com.

I am using Fedora Core 3 with gcc version 3.4.2 20041017 (Red Hat
3.4.2-6.fc3). I got exactly the same error as "unknown" instructions
before my patch.

> 
> > BTW, is mmix-mmixware a real ELF target? When I used mmix-elf, many
> > ELF tests in gas/testsuite/gas/elf failed. Should they be fixed or
> > skipped?
> 
> Again, there is no mmix-elf port.  Use mmix-knuth-mmixware.
> 

But binutils thinks mmix-elf is a valid target. Shouldn't it be
disallowed?


H.J.



More information about the Binutils mailing list