[PATCH] Handling of unary +
Jan Beulich
JBeulich@novell.com
Fri Mar 11 12:30:00 GMT 2005
Standalone + characters were recognized as valid abosulte expressions
in
various contexts.
Built and tested natively on i686-pc-linux-gnu and as cross tools for
a
large number of targets.
Jan
gas/
2005-03-11 Jan Beulich <jbeulich@novell.com>
* expr.c (operand): Merge handling of unary + into that for
unary
-, !, and ~.
---
/home/jbeulich/src/binutils/mainline/2005-03-08/gas/expr.c 2005-03-04
15:51:40.000000000 +0100
+++ 2005-03-08/gas/expr.c 2005-03-10 12:10:56.561175968 +0100
@@ -1011,14 +1011,6 @@ operand (expressionS *expressionP)
mri_char_constant (expressionP);
break;
- case '+':
- /* Do not accept ++e as +(+e).
- Disabled, since the preprocessor removes whitespace. */
- if (0 && *input_line_pointer == '+')
- goto target_op;
- (void) operand (expressionP);
- break;
-
#ifdef TC_M68K
case '"':
/* Double quote is the bitwise not operator in MRI mode. */
@@ -1032,10 +1024,11 @@ operand (expressionS *expressionP)
goto isname;
case '!':
case '-':
+ case '+':
{
- /* Do not accept --e as -(-e)
+ /* Do not accept ++e or --e as +(+e) or -(-e)
Disabled, since the preprocessor removes whitespace. */
- if (0 && c == '-' && *input_line_pointer == '-')
+ if (0 && (c == '-' || c == '+') && *input_line_pointer == c)
goto target_op;
operand (expressionP);
@@ -1052,7 +1045,7 @@ operand (expressionS *expressionP)
}
else if (c == '~' || c == '"')
expressionP->X_add_number = ~ expressionP->X_add_number;
- else
+ else if (c == '!')
expressionP->X_add_number = ! expressionP->X_add_number;
}
else if (expressionP->X_op == O_big
@@ -1099,14 +1092,17 @@ operand (expressionS *expressionP)
else if (expressionP->X_op != O_illegal
&& expressionP->X_op != O_absent)
{
- expressionP->X_add_symbol = make_expr_symbol (expressionP);
- if (c == '-')
- expressionP->X_op = O_uminus;
- else if (c == '~' || c == '"')
- expressionP->X_op = O_bit_not;
- else
- expressionP->X_op = O_logical_not;
- expressionP->X_add_number = 0;
+ if (c != '+')
+ {
+ expressionP->X_add_symbol = make_expr_symbol
(expressionP);
+ if (c == '-')
+ expressionP->X_op = O_uminus;
+ else if (c == '~' || c == '"')
+ expressionP->X_op = O_bit_not;
+ else
+ expressionP->X_op = O_logical_not;
+ expressionP->X_add_number = 0;
+ }
}
else
as_warn (_("Unary operator %c ignored because bad operand
follows"),
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: binutils-mainline-unary-plus.patch
URL: <https://sourceware.org/pipermail/binutils/attachments/20050311/0c26dbb8/attachment.ksh>
More information about the Binutils
mailing list