[PATCH] Handle mtsprg and mfsprg properly for BookE

Alan Modra amodra@bigpond.net.au
Tue Mar 8 23:51:00 GMT 2005


On Tue, Mar 08, 2005 at 11:32:06AM -0500, Jeff Baker wrote:
> I also assumed that one reason for submitting a patch to the mailing 
> list is so that people who know more than I do can review it and then 
> point out where I'm making mistakes.

Well, you've now had some mistakes pointed out.  Don't expect me to
research the relevant architecture documents for you.  It's your job as
patch submitter to do this.  Instead I saw:

"Below is my attempt at a patch to add support for"

"Below is an updated (and I believe more correct) version of this
patch."

"The following patch may also be correct."

That doesn't exactly inspire confidence that you have done any research
to determine what should be done about mt/mfsprg.  So I went out of my
way to look at a BOOKE reference, and found the alternate register
numbering.  Your patch won't be applied until you give some
justification that the choices you've made regarding spr reg numbers are
correct or at least most useful.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre



More information about the Binutils mailing list