[PATCH] ia64: second .xdata fix (was Re: IA64 gas is broken)

James E Wilson wilson@specifixinc.com
Mon Mar 7 20:24:00 GMT 2005


On Mon, 2005-02-28 at 06:25, Jan Beulich wrote:
> 	* config/tc-ia64.c (parse_section_name): Rename to...
> 	(cross_section): In addition to separating the name from the
> rest of
> 	the arguments, also carry out the operation.
> 	...

OK.

Though I find it a little funny that you are adding testcases for odd
section names.  These aren't allowed by the IA-64 assembler manual,
which only allows the same identifiers we allow for variables and
labels.  The fact that we do accept things like .xreal+2 is more an
accident of implementation than intent.  Though considering that it is
obj-elf.c that would have to change, it seems reasonable to work around
this in tc-ia64.c by allowing them.  We shouldn't imply that support for
them is required though.  Maybe the testcase could have a comment
pointing out that these aren't valid IA-64 section names, but we test
them because we got them wrong at one point.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com




More information about the Binutils mailing list