[PATCH] more ARC opcodes cleanups.

Ramana Radhakrishnan ramana.radhakrishnan@codito.com
Thu Mar 3 15:32:00 GMT 2005


Hi Nick,

<snip>
> Sorry no.
> 
> There are three problems:
> 
>   1. You are using a set of #define's for the arithmetic classes, which 
> is better than the straight constants that were being used before, but 
> for something like this an enum is the correct way to go.

Ok. Done.


> 
>   2. When you add comments, please make sure that they follow the 
> guidelines for comment format.  In this case they should be treated as 
> full sentences and end with a full stop followed by two spaces before 
> the */ characters.

Done.


> 
>   3. You appear to be adding in extra blank lines for no really good 
> reason.

Done.

Thanks for reviewing the patch. Ok to commit now ?

cheers
Ramana


-- 
Ramana Radhakrishnan
GNU Tools
codito ergo sum (www.codito.com)

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: arc-opcodes-cleanup-patch-take2
URL: <https://sourceware.org/pipermail/binutils/attachments/20050303/3e5c7661/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: arc-opcodes-cleanup-patch-take2-chlog
URL: <https://sourceware.org/pipermail/binutils/attachments/20050303/3e5c7661/attachment-0001.ksh>


More information about the Binutils mailing list