[PATCH] more ARC opcodes cleanups.

Nick Clifton nickc@redhat.com
Thu Mar 3 14:51:00 GMT 2005


Hi Ramana,

> These are more small cleanups in the backend for the disassembler for 
> ARC. I have just named values given to the decode class as macros and 
> used them . Also removed a redundant case in the switch for the 
> decodingClass.
> 
> Tested as arc-elf32 cross with no regressions on i686-linux
> 
> Can I commit this as obvious ?

Sorry no.

There are three problems:

   1. You are using a set of #define's for the arithmetic classes, which 
is better than the straight constants that were being used before, but 
for something like this an enum is the correct way to go.

   2. When you add comments, please make sure that they follow the 
guidelines for comment format.  In this case they should be treated as 
full sentences and end with a full stop followed by two spaces before 
the */ characters.

   3. You appear to be adding in extra blank lines for no really good 
reason.

If you would like to fix these issues then you may apply the patch.

Cheers
   Nick




More information about the Binutils mailing list