compiling binutils with -DDEBUG

Alan Modra amodra@bigpond.net.au
Tue Mar 1 11:04:00 GMT 2005


On Tue, Mar 01, 2005 at 09:19:49PM +1030, Alan Modra wrote:
> I did a little analysis.  Nowadays, the assertion is always false for
> BFD_ASSEMBLER because symbols have been resolved (write.c:1857) by the
> time this code is reached.  The following would probably fix the
> assertion, but I don't think it's worth worrying about.

	* config/obj-coff.c (fixup_segment): Delete sy_mri_common assertion.

Index: gas/config/obj-coff.c
===================================================================
RCS file: /cvs/src/src/gas/config/obj-coff.c,v
retrieving revision 1.78
diff -u -p -r1.78 obj-coff.c
--- gas/config/obj-coff.c	22 Feb 2005 00:50:05 -0000	1.78
+++ gas/config/obj-coff.c	1 Mar 2005 10:51:57 -0000
@@ -4290,7 +4290,6 @@ fixup_segment (segP, this_segment_type)
       if (add_symbolP != NULL
 	  && add_symbolP->sy_mri_common)
 	{
-	  know (add_symbolP->sy_value.X_op == O_symbol);
 	  add_number += S_GET_VALUE (add_symbolP);
 	  fixP->fx_offset = add_number;
 	  add_symbolP = fixP->fx_addsy = add_symbolP->sy_value.X_add_symbol;

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre



More information about the Binutils mailing list