PATCH: Avoid signed/unsigned warnings in tc-arm.c

[Khem Raj]

Zack Weinberg wrote:

>Khem Raj wrote:
>
>  
>
>>OK. Here is revised patch based on Zack's comments. How about this one?
>>    
>>
>
>I can't approve this, but it looks good to me.  Just a few notes on ChangeLog
>writing:
>
>1) Don't send a ChangeLog as a diff.  By the time the patch is applied, it
>won't apply cleanly.
>
>2) Say what happened, not why.  In this case, a correct change log would read
>
>	* tc-arm.c (struct arm_it): Make operands.reg and operands.imm signed.
>	(parse_operands): Make second argument an unsigned const char *.
>	(do_shift): Make Rm signed.
>
>zw
>  
>
Thanks for reviewing it. Here is renewed patch and Zack's suggestion on 
changelog entry verbatim.

Regards


Khem

gas/ChangeLog

2005-06-23  Khem Raj  <kraj@mvista.com>

    * tc-arm.c (struct arm_it): Make operands.reg and operands.imm signed.
    (parse_operands): Make second argument an unsigned const char *.
    (do_shift): Make Rm signed.



-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff
URL: <https://sourceware.org/pipermail/binutils/attachments/20050624/0e27de29/attachment.ksh>