[PATCH] x86: fix assembler's @got-style relocation handling

Daniel Jacobowitz drow@false.org
Thu Jun 16 23:49:00 GMT 2005


On Thu, Jun 16, 2005 at 08:06:40AM -0700, H. J. Lu wrote:
> On Thu, Jun 16, 2005 at 08:59:23AM -0600, Jan Beulich wrote:
> > >Could you please change those functions to C90 while you are on it?
> > 
> > Wouldn't it make more sense to do this for the whole file, and as a separate checkin?
> > 
> 
> Since you have to change those function prototypes anyway, I don't
> feel we should add more K&R stuff.

In that case, I recommend doing the conversion to C90 first.  Please
don't do it as part of another patch.

-- 
Daniel Jacobowitz
CodeSourcery, LLC



More information about the Binutils mailing list