[Fwd: Re: [PATCH] MIPS32 DSP instructions again]

[Thiemo Seufer]

Chao-ying Fu wrote:
> Hello,
> 
>   From the discussions, most people prefer having
> the option to control generating DSP instructions.
> So, I put DSP options back to GAS as follows.
> 
> -mdsp                   generate DSP instructions
> -no-dsp                 do not generate DSP instructions

Please use -mno-dsp, and resend the patch with a mailer which doesn't
mangle it with tab expansion and additional linebreaks (or send it as
attachment).

[snip]
> *** 7965,7970 ****
> --- 7985,8130 ----
>     return;
>          break;
> 
> +      case '3': /* dsp 3-bit unsigned immediate in bit 21 */
> +        my_getExpression (&imm_expr, s);
> +        check_absolute_expr (ip, &imm_expr);
> +        if ((unsigned long) imm_expr.X_add_number > 7)

Could you use something like if (imm_expr.X_add_number & ~OP_MASK_SA3)
instead of magic numbers for those?


Thiemo