More arm-dis.c cleanups
Nick Clifton
nickc@redhat.com
Wed Jun 8 10:07:00 GMT 2005
Hi Zack,
> Tested on arm-elf; OK to apply?
Please could you test on a COFF and PE based ARM ports as well, just to
make sure.
When you tested did you run the GAS testsuites ? If not, please do so
(for all three targets).
After that then...
> * opcodes/arm-opc.h: Delete; fold contents into ...
> * opcodes/arm-dis.c: ... here.
> Move includes of internal COFF headers next to includes of
> internal ELF headers.
> (streq, WORD_ADDRESS, BDISP, BDISP23): Delete, unused.
> (struct arm_opcode): Rename struct opcode32. Make 'assembler' const.
> (struct thumb_opcode): Rename struct opcode16. Make 'assembler' const.
> (arm_conditional, arm_fp_const, arm_shift, arm_regname, regnames)
> (iwmmxt_wwnames, iwmmxt_wwssnames):
> Make const.
> (regnames): Remove iWMMXt coprocessor register sets.
> (iwmmxt_regnames, iwmmxt_cregnames): New statics.
> (get_arm_regnames): Adjust fourth argument to match above changes.
> (set_iwmmxt_regnames): Delete.
> (print_insn_arm): Constify 'c'. Use ISO syntax for function
> pointer calls. Expand sole use of BDISP. Use iwmmxt_regnames
> and iwmmxt_cregnames, not set_iwmmxt_regnames.
> (print_insn_thumb16, print_insn_thumb32): Constify 'c'. Use
> ISO syntax for function pointer calls.
>
> * include/dis-asm.h (get_arm_regnames): Update prototype.
Approved - please apply. (And thanks for doing this tidy up).
Cheers
Nick
More information about the Binutils
mailing list