[RFA:] ar test failure fix

Hans-Peter Nilsson hans-peter.nilsson@axis.com
Wed Jun 8 03:26:00 GMT 2005


> Date: Wed, 8 Jun 2005 05:20:08 +0200
> From: Hans-Peter Nilsson <hp@axis.com>

> > 	* opncls.c (bfd_fopen): Don't set bfd_error unconditionally.
> 
> But not the same in bfd_fdopenr?
> 
> It it was me, I'd save the previous bfd_error at function start,
> and restore before successful exit.

Uh, that'd be equivalent to just setting it when needed, of
course.  Still, removing the unconditional setting in
bfd_fdopenr (before it calls bfd_fopen, doh) seems right.  I'd
call it obvious if it wasn't that it isn't anymore.

brgds, H-P



More information about the Binutils mailing list