patch: gas support for morpho ms1 cpu

[Nick Clifton]

Hi Aldy,

> 	* config/tc-ms1.c: New.
> 	* config/tc-ms1.h: New.
> 	* testsuite/gas/ms1/allinsn.d: New.
> 	* testsuite/gas/ms1/allinsn.s: New.
> 	* testsuite/gas/ms1/badinsn.s: New.
> 	* testsuite/gas/ms1/badinsn1.s: New.
> 	* testsuite/gas/ms1/badoffsethigh.s: New.
> 	* testsuite/gas/ms1/badoffsetlow.s: New.
> 	* testsuite/gas/ms1/badorder.s: New.
> 	* testsuite/gas/ms1/badreg.s: New.
> 	* testsuite/gas/ms1/badsignedimmhigh.s: New.
> 	* testsuite/gas/ms1/badsignedimmlow.s: New.
> 	* testsuite/gas/ms1/badsyntax.s: New.
> 	* testsuite/gas/ms1/badsyntax1.s: New.
> 	* testsuite/gas/ms1/badunsignedimmhigh.s: New.
> 	* testsuite/gas/ms1/badunsignedimmlow.s: New.
> 	* testsuite/gas/ms1/errors.exp: New.
> 	* testsuite/gas/ms1/ldst.s: New.
> 	* testsuite/gas/ms1/misc.d: New.
> 	* testsuite/gas/ms1/misc.s: New.
> 	* testsuite/gas/ms1/ms1-16-003.d: New.
> 	* testsuite/gas/ms1/ms1-16-003.s: New.
> 	* testsuite/gas/ms1/ms1.exp: New.
> 	* testsuite/gas/ms1/msys.d: New.
> 	* testsuite/gas/ms1/msys.s: New.
> 	* testsuite/gas/ms1/relocs.d: New.
> 	* testsuite/gas/ms1/relocs.exp: New.
> 	* testsuite/gas/ms1/relocs1.s: New.
> 	* testsuite/gas/ms1/relocs2.s: New.

Approved - please apply, but after fixing these small points:

> + void
> + md_begin ()

Should be: "md_begin (void)"

> +       /* Detect consecutive Memory Accesses.  */
> +       if (last_insn_was_memory_access &&
> + 	  CGEN_INSN_ATTR_VALUE (insn.insn, CGEN_INSN_MEMORY_ACCESS) &&
> + 	  ms1_mach == ms1_64_001)

Bad formatting.  The GNU Coding standard requires that "&&" appear at 
the start of a line not the end.  (The same applies to "||").  There are 
several places in your code where this needs to be fixed.

> + symbolS *
> + md_undefined_symbol (char * name ATTRIBUTE_UNUSED)
> + {
> +     return 0;
> + }

Just me being pernicikty here, but "0" is not a pointer.  I would 
suggest returning "NULL" instead.

> +    Copyright (C) 2001, 2002, 2005 Free Software Foundation, Inc.

Another minor point: how can the FSF copyright exist for years in which 
the code did not exist in any FSF repository ?

> + #define md_apply_fix ms1_apply_fix
> + extern void ms1_apply_fix PARAMS ((struct fix *, valueT *, segT)); 

There is no need to use the PARAMS() macro anymore.  We are using ISO 
C90 now.  This occurs in several places.

Cheers
   Nick