[PATCH] ia64 pseudo ops with missing operands

James E Wilson wilson@specifixinc.com
Fri Jan 28 02:20:00 GMT 2005


On Mon, 2005-01-24 at 03:00, Jan Beulich wrote:
> 	* config/tc-ia64.c (parse_operands): Also handle alloc without
> first
> 	input being ar.pfs.

As before, comments should go in the source code instead of in the
ChangeLog entry.

> +      i = CURR_SLOT.opnd[1].X_op == O_register
> +          && CURR_SLOT.opnd[1].X_add_number == REG_AR + AR_PFS ? 2 :
> 1;

The usual way to write this is with parentheses, if you do that, then
emacs will automatically get the indentation right.  E.g.

     i = (CURR_SLOT.opnd[1].X_op == O_register
          && CURR_SLOT.opnd[1].X_add_number == REG_AR + AR_PFS) ? 2 :
1);
and ignore the stupid auto-wrapping mailer.

> +    {"mov",	I, FULL17 | OpX3 (0, 3) | FULL17, {PR, R2}, PSEUDO, 0,
> NULL},

You have FULL17 included twice in the mask.

Otherwise it looks OK.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com




More information about the Binutils mailing list