[PATCH] ia64 application register handling

Jan Beulich JBeulich@novell.com
Thu Jan 27 08:41:00 GMT 2005


>In the emit_one_bundle hunk, inside the #if 0, you accidentally lost a
>comment.  However, this code is long obsolete.  An idesc no longer has
a
>next field; this was dropped even before the code was contributed to
the
>FSF.  I suspect this happened when Bob Manson wrote the ia64-gen.c
>program.  So we should just drop this #if 0 code instead of putting
the
>comment back.

Actually, the comment wasn't lost accidently, but intentionally. But
maybe it should have been modified slightly by adding the word 'other'.
Since this was in an #if 0 block, thus counting as comment, I took the
freedom to slightly change this to

 #if 0
-	  know (!idesc->next);	/* no resolved dynamic ops have
collisions */
+	  else
+	    /* no other resolved dynamic ops have collisions */
+	    know (!get_next_opcode (idesc));
 #endif

Jan



More information about the Binutils mailing list