[patch] gas dwarf2 debug emission

Nathan Sidwell nathan@codesourcery.com
Tue Jan 25 09:43:00 GMT 2005


Alan Modra wrote:
> On Sat, Jan 22, 2005 at 05:42:08PM +0000, Nathan Sidwell wrote:

> o  You're using the function to test whether a section is non-empty,
>    but the code only looks at the first sub-section.  The function ought
>    to run down frch_next, and be called seg_empty_p (or section_empty_p,
>    gas nomenclature is a little confusing).
> 
> o  The function doesn't handle a number of frag types that might have
>    fr_fix zero but still contribute to section size.  Correcting this
>    isn't easy, and unfortunately I think it will be possible to
>    construct cases where it's impossible to guess the frag size at this
>    stage of assembly.  So I'll let this pass if you add a comment.

Like this?  I chose 'seg_not_empty_p' to emphasize that a false result
might not indicate actual emptiness.

built & tested on i686-pc-linux-gnu.

nathan

-- 
Nathan Sidwell    ::   http://www.codesourcery.com   ::     CodeSourcery LLC
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: debug.patch
URL: <https://sourceware.org/pipermail/binutils/attachments/20050125/0aad5a3b/attachment.ksh>


More information about the Binutils mailing list