RFA: elf.sc patch (was Re: RFA: MIPS's _gp symbol and the new orphan-placement code)

Alan Modra amodra@bigpond.net.au
Sat Jan 22 13:32:00 GMT 2005


On Sat, Jan 22, 2005 at 10:43:17AM +0000, Richard Sandiford wrote:
> 	* scripttempl/elf.sc: Insert ". = .;" before OTHER_GOT_SYMBOLS.

I'd prefer you do this by modifying OTHER_GOT_SYMBOLS in elf32bmip.sh
and elf32bmipn32-defs.sh, perhaps with a comment.  OTHER_GOT_SYMBOLS
may not always be used to only define symbols, and placing ".=.;" in the
source close to where you assign a symbol value might clue future
hackers to guard other random symbol assignments.  Also, four other
scripts use OTHER_GOT_SYMBOLS, so if you change elf.sc you really ought
to change them too.  Patch to emulparams/* preapproved.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre



More information about the Binutils mailing list