[PATCH] MIPS gas: Fix macro expansions for .set noat

Eric Christopher echristo@redhat.com
Thu Feb 17 13:53:00 GMT 2005


> Hm, OTOH it could simply be sloppy coding, and falling over it
> is not necessarily the right thing to do. I plan to commit the
> appended patch, it partially reverts the earlier change.
> 
> Comments?
> 
> 
> Thiemo
> 
> 
> 2005-02-16  Thiemo Seufer  <seufer@csv.ica.uni-stuttgart.de>
> 
> 	/gas/ChangeLog
> 	* config/tc-mips.c (macro): Don't fail but warn on $at uses
> 	after .set noat, it may only be sloppy coding.  Don't try to
> 	avoid $at use by sacrificing the target register before it is
> 	stored, it won't work.

Actually I disagree. If the user used .set noat and has sloppy coding we
should fall over like we would for .set nomacro or such.

-eric



More information about the Binutils mailing list