Fix for compile time warning in binutils/nlmconv.c

Nick Clifton nickc@redhat.com
Wed Feb 16 19:22:00 GMT 2005


Hi Ian,

> However, your patch is not a good idea.  There are undoubtedly systems
> out there which declare localtime with different parameter types--in
> particular omitting the const--so your patch will change those
> systems from a warning to an error.
> 
> Better to remove the declaration entirely.  Modern systems don't need
> the declaration, and older systems will most likely be OK with the
> warning.

Thanks for the explanation - I agree that removing the prototype is the 
simplest solution for now, so I have checked in the obvious patch to do 
this.

Cheers
   Nick

binutils/ChangeLog
2005-02-16  Nick Clifton  <nickc@redhat.com>

	* nlmconv.c: Remove prototype for localetime altogether.  It
	should not be needed on modern systems and older systems can live
	with the warning.



More information about the Binutils mailing list