[PATCH] Additional TC_EQUAL_IN_INSN check

Nick Clifton nickc@redhat.com
Wed Feb 16 17:54:00 GMT 2005


Hi Catherine,

> This patch adds an argument to TC_EQUAL_IN_INSN so that the current string
> can be checked.

Why is this needed ?  Do you have a port where the current semantics for 
TC_EQUAL_IN_INSN are insufficient ?  [The string 's' can be deduced from 
  input_line_pointer, so why pass it as an extra argument ?]

> It also adds an additional check for TC_EQUAL_IN_INSN in
> read_a_source_file.  

Again - why is is this necessary ?  Couldn't the if-statement be 
rearranged so that there was only one invocation of TC_EQUAL_IN_INSN ?

Cheers
   Nick



More information about the Binutils mailing list