[patch committed] Fix gas test failures on sh64-unknown-{linux,netbsd}

Kaz Kojima kkojima@rr.iij4u.or.jp
Thu Aug 18 11:24:00 GMT 2005


Hi,

Many tests run by testsuite/gas/sh/arch/arch.exp fail on
sh64-unknown-linux-gnu and sh64-unknown-netbsd because
the assembler for these targets ignore -isa option.  I've
checked the appended patch in to fix it.

Regards,
	kaz
--
2005-08-18  Kaz Kojima  <kkojima@rr.iij4u.or.jp>

	* config/tc-sh64.c (sh64_target_format): Check preset_target_arch
	to confirm that no ISA is specified.

diff -uprN ORIG/src/gas/config/tc-sh64.c LOCAL/src/gas/config/tc-sh64.c
--- ORIG/src/gas/config/tc-sh64.c	2005-06-22 08:27:47.000000000 +0900
+++ LOCAL/src/gas/config/tc-sh64.c	2005-08-16 10:00:31.000000000 +0900
@@ -2928,14 +2928,14 @@ sh64_target_format (void)
 {
 #ifdef TE_NetBSD
   /* For NetBSD, if the ISA is unspecified, always use SHmedia.  */
-  if (sh64_isa_mode == sh64_isa_unspecified)
+  if (preset_target_arch == 0 && sh64_isa_mode == sh64_isa_unspecified)
     sh64_isa_mode = sh64_isa_shmedia;
 
   /* If the ABI is unspecified, select a default: based on how
      we were configured: sh64 == sh64_abi_64, else sh64_abi_32.  */
   if (sh64_abi == sh64_abi_unspecified)
     {
-      if (sh64_isa_mode == sh64_isa_shcompact)
+      if (preset_target_arch != 0 || sh64_isa_mode == sh64_isa_shcompact)
 	sh64_abi = sh64_abi_32;
       else if (strncmp (TARGET_CPU, "sh64", 4) == 0)
         sh64_abi = sh64_abi_64;
@@ -2945,7 +2945,7 @@ sh64_target_format (void)
 #endif
 
 #ifdef TE_LINUX
-  if (sh64_isa_mode == sh64_isa_unspecified)
+  if (preset_target_arch == 0 && sh64_isa_mode == sh64_isa_unspecified)
     sh64_isa_mode = sh64_isa_shmedia;
 
   if (sh64_abi == sh64_abi_unspecified)



More information about the Binutils mailing list