[patch] More Thumb2 condexec bugs
Tue Aug 9 08:50:00 GMT 2005
On Mon, 2005-08-08 at 20:50, Paul Brook wrote:
> The attached patch fixes some mode thumb2 conditional instruction encodings.
> Specifically the 16-bit forms do not set the condition codes when inside an
> IT block.
> Tested on arm-none-eabi.
> 2005-08-08 Paul Brook <email@example.com>
> * config/tc-arm.c (do_t_mov_cmp): Fix encoding of 16-bit conditional
> (do_t_mvn_tst, do_t_neg, do_t_shift): Ditto.
> * gas/arm/thumb2_it.s: Add more instruction variants.
> * gas/arm/thumb2_it.d: Ditto.
The tc-arm.c changes are fine. However, I'm not particularly keen on
the dump file for the test. For example:
> Index: testsuite/gas/arm/thumb2_it.d
> +0+040 <[^>]+> 0048 lsl.* r0, r1, #1
This patttern would match any amount of random text after the mnemonic
(I think it should really be)
+0+040 <[^>]+> 0048 lsl(eq|s) r0, r1, #1
And ultimately (once the disassembler is fixed) the 's' alternative
should be removed (since this particular insn is conditionally
More information about the Binutils