Why does gas have both S_IS_EXTERNAL and S_IS_EXTERN?

[Nick Clifton]

Hi H. J.

>>>S_IS_EXTERN just calls S_IS_EXTERNAL. Why does gas need it?

>>It doesn't.
>>
>>In the non BFD_ASSEMBLER case, in obj-coff.h, S_IS_EXTERN and
>>S_IS_EXTERNAL are not identical.  Specifically, S_IS_EXTERNAL will
>>return true for a common symbol, and S_IS_EXTERN will not.  This is
>>almost certainly a bug.

> Should I submit a patch to remove S_IS_EXTERN?

Yes please.

Cheers
   Nick