Remove parameter names from libiberty.h

Ian Lance Taylor ian@airs.com
Thu Apr 14 20:58:00 GMT 2005


"Dave Korn" <dave.korn@artimi.com> writes:

>   My two cents is that it's asking for trouble to #define an all-lower case
> word, particularly an extremely common one such as 'mode'.  I had a quick
> grep but couldn't figure out where it's coming from.  I guess that sort of
> thing is vaguely-ok-if-innately-fragile if it's being defined by the
> m88k-dis source file, but if there's a public header in either binutils or
> libiberty that's doing it, I'd think it ought to change.

It was coming from include/opcode/m88k.h, and it's already been fixed
there by Paul Brook.

Still, I don't think we should use parameter names for well understood
functions.  There is no ideal policy here, but omitting unnecessary
parameter names seems to me to be wise regardless.

Ian



More information about the Binutils mailing list