objcopy fails silently with an empty input file

Nick Clifton nickc@redhat.com
Wed Apr 13 16:08:00 GMT 2005


Hi Shaun,

> objcopy silently fails when the input file is empty. I'd rather it
> didn't fail -- this used to work in previous versions -- but it
> definitely shouldn't fail silently.

Please could you try the attached patch and let me know if you have any 
problems with it ?

Cheers
   Nick

binutils/ChangeLog
2005-04-13  Nick Clifton  <nickc@redhat.com>

	* objcopy.c (copy_file): Emit a message when skipping an empty
	input file.

Index: binutils/objcopy.c
===================================================================
RCS file: /cvs/src/src/binutils/objcopy.c,v
retrieving revision 1.77
diff -c -3 -p -r1.77 objcopy.c
*** binutils/objcopy.c	15 Mar 2005 17:45:18 -0000	1.77
--- binutils/objcopy.c	13 Apr 2005 16:06:23 -0000
*************** copy_file (const char *input_filename, c
*** 1701,1706 ****
--- 1701,1707 ----

     if (get_file_size (input_filename) < 1)
       {
+       non_fatal (_("%s: empty input file"), input_filename);
         status = 1;
         return;
       }



More information about the Binutils mailing list