[PATCH] gas should honor original section type (was Re: ELF section identification and gld)

Nick Clifton nickc@redhat.com
Thu Sep 9 11:10:00 GMT 2004


Hi Jan,

> This patch attempts to address this. Built and tested on
> i686-pc-linux-gnu.

> bfd/
> 2004-08-27 Jan Beulich <jbeulich@novell.com>
> 
> 	* elf.c (_bfd_elf_new_section_hook): Only set various section
> 	characteristics on new sections.
> 
> gas/config/
> 2004-08-27 Jan Beulich <jbeulich@novell.com>
> 
> 	* confif/obj-elf.c (obj_elf_change_section): Only set type and
> 	attributes on new sections. Emit warning when type on
> re-declared
> 	section doesn't match.
> 
> gas/testsuite/
> 2004-08-27 Jan Beulich <jbeulich@novell.com>
> 
> 	* section5.*: New.

Unfortunately this patch appears to introduce quite a few new testsuite 
failures in other toolchains.  In particular I found lots of failures of 
the new section5 test because it only checks for REL in the output and 
does not include RELA.  (This affected toolchains such as: 
alpha-linux-gnu and sh-elf).

Other toolchains had even more difficulties.  The patch introduced 51 
new unexpected failures for GAS tests and 47 new unexpected failures for 
LD tests for the mmix-mmixware toolchain.  The mips64-linux toolchain 
had 13 and 15 new unexpected failures respectively, and the 
sparc64-linux-gnu toolchain has 21 and 9 new failures.

Please could you investigate and resolve these issues and then resubmit 
your patch ?

Cheers
   Nick




More information about the Binutils mailing list