Fix relro when COMMONPAGESIZE < MAXPAGESIZE

[Hans-Peter Nilsson]

On Tue, 7 Sep 2004, Jakub Jelinek wrote:
> On Thu, Sep 02, 2004 at 05:39:34PM +0200, Andreas Schwab wrote:
> > Adjusting the relro end address during DATA_SEGMENT_ALIGN throws aways any
> > previous data segment alignment, causing the resulting binary to contain a
> > big hole.
>
> Can you post readelf -WS output before and after the patch?
> The big hole was certainly intended there, so that MAXPAGESIZE is properly
> honored.  After all, it is just diskspace (well, ld creates sparse file),
> not memory.

"Diskspace" might be solid-state media (usually flash ROM) which
is certainly not inexpensive. (And the flash file-system might
not support sparse files.)

Please, whenever you make a change to increase the size of
anything available at execution time, please remember that not
all "diskspace" is cheap, and make the size-increasing
functionality an *option*.

brgds, H-P