PR 161/251 patch causing massive link time regression

Alan Modra amodra@bigpond.net.au
Fri Oct 15 02:35:00 GMT 2004


On Thu, Oct 14, 2004 at 04:19:19PM -0400, Jakub Jelinek wrote:
> On Thu, Oct 14, 2004 at 11:48:47AM -0700, H. J. Lu wrote:
> > It is OK. We can put restriction on group signature when it should
> > match a linkonce section.
> > 
> > > At least the intent of the patch (unless I goofed up) is doing exactly what
> > > linker did without this patch, but only try to match sections that have the
> > > same base section name (resp. comdat group name), where base section name
> > > is section name with ^\.gnu\.linkonce\.[^.]*\. prefix if present stripped.
> > > 
> > 
> > It looks good to me. How much speed up did yot get with it?
> 
> On the specific test (linking libgklayout.so) it is back on the old
> speed, i.e. on my x86-64 back to ~ 13s down from ~ 44s.

Looks OK to me too.  Please commit.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre



More information about the Binutils mailing list