[PATCH] Add --warn-shared-textrel option to ld

Nick Clifton nickc@redhat.com
Thu Oct 7 14:46:00 GMT 2004


Hi Jeff,

>>    * The formatting of the code added to elflink.c does not follow the 
>> GNU Coding Standards; (the opening curly brace should be on its own
>> line).
>>
>>    * The patch adds a new command line switch to the linker, but it does
>> not add documentation on this switch to the ld.texinfo file, nor does it
>> add a line to the ld/NEWS file.

> How about now?

Better - thanks:

> 2004-10-01  Jeff Baker  <jbaker@qnx.com>
> 	* elflink.c (_bfd_elf_add_dynamic_entry): Add code to
> 	warn if adding a DT_TEXTREL to a shared object and
> 	--warn-shared-textrel was specified.
> 
> 2004-10-01  Jeff Baker  <jbaker@qnx.com>
> 	* bfdlink.h (bfd_link_info): Add boolean
> 	warn_shared_textrel.
> 
> 2004-10-01  Jeff Baker  <jbaker@qnx.com>
> 	* NEWS: Added mention of --warn-shared-textrel option.
> 	* ld.texinfo: Add documentation for --warn-shared-textrel.
> 	* lexsup.c: Handle --warn-shared-textrel option.

Approved and applied.

Cheers
   Nick



More information about the Binutils mailing list