[committed] small one liner in gas

Daniel Jacobowitz drow@false.org
Tue Oct 5 01:49:00 GMT 2004


On Mon, Oct 04, 2004 at 04:25:06PM -0700, Eric Christopher wrote:
> Fixes a small bug Zack ran into with:
> 
> lw $3,%half($gp)
> 
> where he was getting an internal error in gas for this.
> 
> The fx_size was 4 because that's the size of the data worked on, not 2
> which is the size in the howto. Anyhow, instead of changing the assert
> to 4 I just removed it since none of the other relocations have asserts
> in them.

Waitasec...

> -      assert (fixP->fx_size == 2);
>        if (fixP->fx_done)
>  	md_number_to_chars (buf, *valP, 2);

Won't that get the wrong location for big-endian?  The code for LO16
has an endian correction.

[Zack, I think that doesn't matter for us, since the only place we'll
be generating %half fx_done won't get set.]

-- 
Daniel Jacobowitz



More information about the Binutils mailing list