[PATCH] some x86 instructions tagged with incorrect CPU type

H. J. Lu hjl@lucon.org
Tue Nov 16 19:40:00 GMT 2004


On Mon, Nov 15, 2004 at 03:05:00PM +1030, Alan Modra wrote:
> On Thu, Nov 04, 2004 at 11:20:37AM +0100, Jan Beulich wrote:
> > Various instructions where not tagged with the right required feature
> > set
> > identifiers, and some CPUs had by default features enabled which they
> > don't
> > always provide. This tries to rectify this. Additionally, it provides
> > the
> > ability to add certain feature groups to the user selected CPU (i.e.
> > MMX
> > instructions with a Pentium CPU).
> 
> HJ, would you please review this patch?  I figure you have more of a
> vested interest in x86 these days than I do..
> 

The first problem is the patched assemebler failed "make check" for
x86-64. I got

/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:
Assembler messages:
/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3: Warning: `aaa' is not supported in 64-bit mode
/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3: Error: suffix or operands invalid for `aaa'

instead of

/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:
Assembler messages:
/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3: Error: suffix or operands invalid for `aaa'

I would prefer just

/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:
Assembler messages:
/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3: Error: `aaa' is not supported in 64-bit mode


H.J.



More information about the Binutils mailing list