Cygwin tester? Was: [rfa] Add bfd-in-memory io vector
Andrew Cagney
cagney@gnu.org
Wed May 5 15:57:00 GMT 2004
Dave, Danny, thanks!
> From: "Danny Smith"
> |
> | From: "Danny Smith"
> |
> | |
> | | | > On Sat, May 01, 2004 at 02:10:31PM -0400, Andrew Cagney wrote:
> | | | >
> | | | >>> The testing comment still applies though.
> | | | >
> | | | >
> | | | > Given DJ's comment, I think you should test this on cygwin before
> | | | > committing. If you can't do this yourself, convince someone else
> | | | > to do so for you. OK to commit once you've done this.
> | | | >
>
> Hi,
>
> Although the patchset works fine (if I add the checks for HAVE_GET[GU]ID)
> when building .exe files on pe targets, it fails when building dll's
> (segfault in bfd/bfdio.c:bfd_bread when forwarding args to iovec->bread)
I'll add this to the patch.
> With binutils built with CFLAGS="-g -O2", gcc-3.4.0, mingw32:
>
> cat > foo.c
> int foo = 1;
> ^Z
> gcc -shared -ofoo.dll foo.c
>
> raises the segfault in bfd_bread.
>
> Actually, the above testcase fails since your 21-April patch.
>
> The problem occurs when pe-dll.c code calls bread with a NULL file, asking for zero bytes
> (see comment in cache.c:cache_bread).
>
> The problem can be avoided by doing the cache_bread FIXME in bfd_bread, ie:
>
> *** bfdio.c.cagney Mon May 03 10:02:13 2004
> --- bfdio.c Tue May 04 11:26:40 2004
> *************** bfd_bread (void *ptr, bfd_size_type size
> *** 104,109 ****
> --- 104,113 ----
> {
> size_t nread;
>
> + /* See FIXME in cache.c:cache_bread(). */
> + if (size == 0)
> + return 0;
> +
> nread = abfd->iovec->bread (abfd, ptr, size);
> if (nread != (size_t) -1)
> abfd->where += nread;
Outch, thanks. I think I'll move the fixme as well as a separate patch.
> With above patch, simple dll build is okay.
> But this looks a bit strange in peicode.h:pe_ILF_build_a_bfd()
>
> + vars.bim = _bfd_in_memory (abfd, abfd->flags, vars.bim->buffer,
> + vars.bim->size);
Oops, yes.
Andrew
> Should that be:
>
> vars.bim = _bfd_in_memory (abfd, abfd->flags, bim.buffer, bim.size);
>
>
> Danny
More information about the Binutils
mailing list